Conversation
Hi, not sure if this is still maintained but I come across this code from an article online and found and issue. When I had no goals assigned I was noticing plans were still being built so I checked and found the inState() function would still return true if it's test parm was empty. The comment says it should return true so I added some code to return true when test is empty. Was also wonder if there was a reason why you did not use state.Contains(t) rather than looping over state and checking each value? I think the built in Contains() function dose pretty much the same thing?
vc-chitrang
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, not sure if this is still maintained but I come across this code from an article online and found an issue.
When I had no goals assigned I was noticing plans were still being built so I checked and found the inState() function would still return true if it's test parm was empty. The comment says it should return false so I put in a PR.
Was also wonder if there was a reason why you did not use state.Contains(t) rather than looping over state and checking each value? I think the built in Contains() function dose pretty much the same thing?